From b718b1c87038d44f2519f50d2df25454aad5f926 Mon Sep 17 00:00:00 2001
From: Taylor Thomas <thomastaylor312@gmail.com>
Date: Fri, 6 Apr 2018 15:43:37 -0700
Subject: [PATCH] fix(package): Adds missing `set-string` flag and parameter
A recent PR (#3471) wasn't up to date with the latest master changes.
This fixes the issue and adds the right number of parameters to the
`vals` function call.
---
cmd/helm/package.go | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/cmd/helm/package.go b/cmd/helm/package.go
index 4b2e6b398..bf171e534 100644
--- a/cmd/helm/package.go
+++ b/cmd/helm/package.go
@@ -55,6 +55,7 @@ type packageCmd struct {
path string
valueFiles valueFiles
values []string
+ stringValues []string
key string
keyring string
version string
@@ -99,6 +100,7 @@ func newPackageCmd(out io.Writer) *cobra.Command {
f := cmd.Flags()
f.VarP(&pkg.valueFiles, "values", "f", "specify values in a YAML file or a URL(can specify multiple)")
f.StringArrayVar(&pkg.values, "set", []string{}, "set values on the command line (can specify multiple or separate values with commas: key1=val1,key2=val2)")
+ f.StringArrayVar(&pkg.stringValues, "set-string", []string{}, "set STRING values on the command line (can specify multiple or separate values with commas: key1=val1,key2=val2)")
f.BoolVar(&pkg.save, "save", true, "save packaged chart to local chart repository")
f.BoolVar(&pkg.sign, "sign", false, "use a PGP private key to sign this package")
f.StringVar(&pkg.key, "key", "", "name of the key to use when signing. Used if --sign is true")
@@ -137,7 +139,7 @@ func (p *packageCmd) run() error {
return err
}
- overrideVals, err := vals(p.valueFiles, p.values)
+ overrideVals, err := vals(p.valueFiles, p.values, p.stringValues)
if err != nil {
return err
}
--
GitLab