From e02802ba95e17c2a21dceeb56df893c01001e5d8 Mon Sep 17 00:00:00 2001
From: Michelle Noorali <michellemolu@gmail.com>
Date: Wed, 4 Apr 2018 15:54:12 -0400
Subject: [PATCH] ref(pkg/tiller): clarify reuseValues comment
---
pkg/tiller/release_update.go | 2 +-
pkg/tiller/release_update_test.go | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/pkg/tiller/release_update.go b/pkg/tiller/release_update.go
index cb8b57792..6f5d37331 100644
--- a/pkg/tiller/release_update.go
+++ b/pkg/tiller/release_update.go
@@ -80,7 +80,7 @@ func (s *ReleaseServer) prepareUpdate(req *services.UpdateReleaseRequest) (*rele
return nil, nil, err
}
- // If new values were not supplied in the upgrade, re-use the existing values.
+ // determine if values will be reused
if err := s.reuseValues(req, currentRelease); err != nil {
return nil, nil, err
}
diff --git a/pkg/tiller/release_update_test.go b/pkg/tiller/release_update_test.go
index 0189201d1..a1b9a4bff 100644
--- a/pkg/tiller/release_update_test.go
+++ b/pkg/tiller/release_update_test.go
@@ -260,7 +260,7 @@ func TestUpdateRelease_ReuseValues(t *testing.T) {
t.Errorf("Expected chart values to be %q, got %q", expect, res.Release.Chart.Values.Raw)
}
// This should have the newly-passed overrides and any other computed values. `name: value` comes from release Config via releaseStub()
- expect = "name: value\nname2: val2"
+ expect = "name: value\nname2: val2\n"
if res.Release.Config != nil && res.Release.Config.Raw != expect {
t.Errorf("Expected request config to be %q, got %q", expect, res.Release.Config.Raw)
}
--
GitLab