From fbda50a452b6db58faf2016b17c206ee27ddc999 Mon Sep 17 00:00:00 2001
From: Caleb Delnay <calebdelnay@gmail.com>
Date: Tue, 18 Sep 2018 17:00:30 -0400
Subject: [PATCH] Fix credentials not set for ResolveChartVersion default HTTP
client (#4662)
Fixes Issue #4299 and Issue #4445
Signed-off-by: Caleb Delnay <calebdelnay@gmail.com>
---
pkg/downloader/chart_downloader.go | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/pkg/downloader/chart_downloader.go b/pkg/downloader/chart_downloader.go
index 92c8f9165..5e6287299 100644
--- a/pkg/downloader/chart_downloader.go
+++ b/pkg/downloader/chart_downloader.go
@@ -170,8 +170,11 @@ func (c *ChartDownloader) ResolveChartVersion(ref, version string) (*url.URL, ge
if err != nil {
return u, nil, err
}
- getter, err := getterConstructor(ref, "", "", "")
- return u, getter, err
+ g, err := getterConstructor(ref, "", "", "")
+ if t, ok := g.(*getter.HttpGetter); ok {
+ t.SetCredentials(c.Username, c.Password)
+ }
+ return u, g, err
}
return u, nil, err
}
--
GitLab