An error occurred while loading the file. Please try again.
-
Matthew Fisher authored
To match the convention of `helm install`, `helm uninstall` is the inverse. Other tangential changes in this PR: - StatusDeleting has been changed to StatusUninstalling - StatusDeleted has been changed to StatusUninstalled - `helm list --deleted` has been changed to `helm list --uninstalled` - `helm list --deleting` has been changed to `helm list --uninstalling` - `helm.DeleteOption` and all delete options have been renamed to `helm.UninstallOption` I have not made any changes to the "helm.sh/hook-delete-policy", "pre-delete" and "post-delete" hook annotations because 1. it's a major breaking change to existing helm charts, which we've commited to NOT break in Helm 3 2. there is no "helm.sh/hook-install-policy" to pair with "helm.sh/hook-uninstall-policy", so delete still makes sense here `helm delete` and `helm del` have been added as aliases to `helm uninstall`, so `helm delete` and `helm del` still works as is.
Unverified195d21d5
/*Copyright 2016 The Kubernetes Authors All rights reserved.Licensed under the Apache License, Version 2.0 (the "License");you may not use this file except in compliance with the License.You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0Unless required by applicable law or agreed to in writing, softwaredistributed under the License is distributed on an "AS IS" BASIS,WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.See the License for the specific language governing permissions andlimitations under the License.*/package tillerimport ( "bytes" "reflect" "strings" "testing" "k8s.io/helm/pkg/hapi" "k8s.io/helm/pkg/hapi/chart" "k8s.io/helm/pkg/hapi/release")func TestUpdateRelease(t *testing.T) { rs := rsFixture(t) rel := releaseStub() rs.Releases.Create(rel) req := &hapi.UpdateReleaseRequest{ Name: rel.Name, Chart: &chart.Chart{ Metadata: &chart.Metadata{Name: "hello"}, Templates: []*chart.File{ {Name: "templates/hello", Data: []byte("hello: world")}, {Name: "templates/hooks", Data: []byte(manifestWithUpgradeHooks)}, }, }, } res, err := rs.UpdateRelease(req) if err != nil { t.Fatalf("Failed updated: %s", err) } if res.Name == "" { t.Errorf("Expected release name.") } if res.Name != rel.Name { t.Errorf("Updated release name does not match previous release name. Expected %s, got %s", rel.Name, res.Name) } if res.Namespace != rel.Namespace { t.Errorf("Expected release namespace '%s', got '%s'.", rel.Namespace, res.Namespace) } updated := compareStoredAndReturnedRelease(t, *rs, res) if len(updated.Hooks) != 1 { t.Fatalf("Expected 1 hook, got %d", len(updated.Hooks)) } if updated.Hooks[0].Manifest != manifestWithUpgradeHooks { t.Errorf("Unexpected manifest: %v", updated.Hooks[0].Manifest) }7172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140
if updated.Hooks[0].Events[0] != release.HookPostUpgrade {
t.Errorf("Expected event 0 to be post upgrade")
}
if updated.Hooks[0].Events[1] != release.HookPreUpgrade {
t.Errorf("Expected event 0 to be pre upgrade")
}
if len(updated.Manifest) == 0 {
t.Errorf("Expected manifest in %v", res)
}
if res.Config == nil {
t.Errorf("Got release without config: %#v", res)
} else if !bytes.Equal(res.Config, rel.Config) {
t.Errorf("Expected release values %q, got %q", rel.Config, res.Config)
}
if !strings.Contains(updated.Manifest, "---\n# Source: hello/templates/hello\nhello: world") {
t.Errorf("unexpected output: %s", updated.Manifest)
}
if res.Version != 2 {
t.Errorf("Expected release version to be %v, got %v", 2, res.Version)
}
edesc := "Upgrade complete"
if got := res.Info.Description; got != edesc {
t.Errorf("Expected description %q, got %q", edesc, got)
}
}
func TestUpdateRelease_ResetValues(t *testing.T) {
rs := rsFixture(t)
rel := releaseStub()
rs.Releases.Create(rel)
req := &hapi.UpdateReleaseRequest{
Name: rel.Name,
Chart: &chart.Chart{
Metadata: &chart.Metadata{Name: "hello"},
Templates: []*chart.File{
{Name: "templates/hello", Data: []byte("hello: world")},
{Name: "templates/hooks", Data: []byte(manifestWithUpgradeHooks)},
},
},
ResetValues: true,
}
res, err := rs.UpdateRelease(req)
if err != nil {
t.Fatalf("Failed updated: %s", err)
}
// This should have been unset. Config: &chart.Config{Raw: `name: value`},
if len(res.Config) > 0 {
t.Errorf("Expected chart config to be empty, got %q", res.Config)
}
}
// This is a regression test for bug found in issue #3655
func TestUpdateRelease_ComplexReuseValues(t *testing.T) {
rs := rsFixture(t)
installReq := &hapi.InstallReleaseRequest{
Namespace: "spaced",
Chart: &chart.Chart{
Metadata: &chart.Metadata{Name: "hello"},
Templates: []*chart.File{
{Name: "templates/hello", Data: []byte("hello: world")},
{Name: "templates/hooks", Data: []byte(manifestWithHook)},
},
Values: []byte("defaultFoo: defaultBar"),
141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210
},
Values: []byte("foo: bar"),
}
t.Log("Running Install release with foo: bar override")
rel, err := rs.InstallRelease(installReq)
if err != nil {
t.Fatal(err)
}
req := &hapi.UpdateReleaseRequest{
Name: rel.Name,
Chart: &chart.Chart{
Metadata: &chart.Metadata{Name: "hello"},
Templates: []*chart.File{
{Name: "templates/hello", Data: []byte("hello: world")},
{Name: "templates/hooks", Data: []byte(manifestWithUpgradeHooks)},
},
Values: []byte("defaultFoo: defaultBar"),
},
}
t.Log("Running Update release with no overrides and no reuse-values flag")
rel, err = rs.UpdateRelease(req)
if err != nil {
t.Fatalf("Failed updated: %s", err)
}
expect := "foo: bar"
if rel.Config != nil && !bytes.Equal(rel.Config, []byte(expect)) {
t.Errorf("Expected chart values to be %q, got %q", expect, string(rel.Config))
}
req = &hapi.UpdateReleaseRequest{
Name: rel.Name,
Chart: &chart.Chart{
Metadata: &chart.Metadata{Name: "hello"},
Templates: []*chart.File{
{Name: "templates/hello", Data: []byte("hello: world")},
{Name: "templates/hooks", Data: []byte(manifestWithUpgradeHooks)},
},
Values: []byte("defaultFoo: defaultBar"),
},
Values: []byte("foo2: bar2"),
ReuseValues: true,
}
t.Log("Running Update release with foo2: bar2 override and reuse-values")
rel, err = rs.UpdateRelease(req)
if err != nil {
t.Fatalf("Failed updated: %s", err)
}
// This should have the newly-passed overrides.
expect = "foo: bar\nfoo2: bar2\n"
if rel.Config != nil && !bytes.Equal(rel.Config, []byte(expect)) {
t.Errorf("Expected request config to be %q, got %q", expect, string(rel.Config))
}
req = &hapi.UpdateReleaseRequest{
Name: rel.Name,
Chart: &chart.Chart{
Metadata: &chart.Metadata{Name: "hello"},
Templates: []*chart.File{
{Name: "templates/hello", Data: []byte("hello: world")},
{Name: "templates/hooks", Data: []byte(manifestWithUpgradeHooks)},
},
Values: []byte("defaultFoo: defaultBar"),
},
Values: []byte("foo: baz"),
211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280
ReuseValues: true,
}
t.Log("Running Update release with foo=baz override with reuse-values flag")
rel, err = rs.UpdateRelease(req)
if err != nil {
t.Fatalf("Failed updated: %s", err)
}
expect = "foo: baz\nfoo2: bar2\n"
if rel.Config != nil && !bytes.Equal(rel.Config, []byte(expect)) {
t.Errorf("Expected chart values to be %q, got %q", expect, rel.Config)
}
}
func TestUpdateRelease_ReuseValues(t *testing.T) {
rs := rsFixture(t)
rel := releaseStub()
rs.Releases.Create(rel)
req := &hapi.UpdateReleaseRequest{
Name: rel.Name,
Chart: &chart.Chart{
Metadata: &chart.Metadata{Name: "hello"},
Templates: []*chart.File{
{Name: "templates/hello", Data: []byte("hello: world")},
{Name: "templates/hooks", Data: []byte(manifestWithUpgradeHooks)},
},
// Since reuseValues is set, this should get ignored.
Values: []byte("foo: bar\n"),
},
Values: []byte("name2: val2"),
ReuseValues: true,
}
res, err := rs.UpdateRelease(req)
if err != nil {
t.Fatalf("Failed updated: %s", err)
}
// This should have been overwritten with the old value.
expect := "name: value\n"
if res.Chart.Values != nil && !bytes.Equal(res.Chart.Values, []byte(expect)) {
t.Errorf("Expected chart values to be %q, got %q", expect, res.Chart.Values)
}
// This should have the newly-passed overrides and any other computed values. `name: value` comes from release Config via releaseStub()
expect = "name: value\nname2: val2\n"
if res.Config != nil && !bytes.Equal(res.Config, []byte(expect)) {
t.Errorf("Expected request config to be %q, got %q", expect, res.Config)
}
compareStoredAndReturnedRelease(t, *rs, res)
}
func TestUpdateRelease_ResetReuseValues(t *testing.T) {
// This verifies that when both reset and reuse are set, reset wins.
rs := rsFixture(t)
rel := releaseStub()
rs.Releases.Create(rel)
req := &hapi.UpdateReleaseRequest{
Name: rel.Name,
Chart: &chart.Chart{
Metadata: &chart.Metadata{Name: "hello"},
Templates: []*chart.File{
{Name: "templates/hello", Data: []byte("hello: world")},
{Name: "templates/hooks", Data: []byte(manifestWithUpgradeHooks)},
},
},
ResetValues: true,
ReuseValues: true,
}
res, err := rs.UpdateRelease(req)
if err != nil {
281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350
t.Fatalf("Failed updated: %s", err)
}
// This should have been unset. Config: &chart.Config{Raw: `name: value`},
if len(res.Config) > 0 {
t.Errorf("Expected chart config to be empty, got %q", res.Config)
}
compareStoredAndReturnedRelease(t, *rs, res)
}
func TestUpdateReleaseFailure(t *testing.T) {
rs := rsFixture(t)
rel := releaseStub()
rs.Releases.Create(rel)
rs.KubeClient = newUpdateFailingKubeClient()
req := &hapi.UpdateReleaseRequest{
Name: rel.Name,
DisableHooks: true,
Chart: &chart.Chart{
Metadata: &chart.Metadata{Name: "hello"},
Templates: []*chart.File{
{Name: "templates/something", Data: []byte("hello: world")},
},
},
}
res, err := rs.UpdateRelease(req)
if err == nil {
t.Error("Expected failed update")
}
if updatedStatus := res.Info.Status; updatedStatus != release.StatusFailed {
t.Errorf("Expected FAILED release. Got %s", updatedStatus)
}
compareStoredAndReturnedRelease(t, *rs, res)
expectedDescription := "Upgrade \"angry-panda\" failed: Failed update in kube client"
if got := res.Info.Description; got != expectedDescription {
t.Errorf("Expected description %q, got %q", expectedDescription, got)
}
oldRelease, err := rs.Releases.Get(rel.Name, rel.Version)
if err != nil {
t.Errorf("Expected to be able to get previous release")
}
if oldStatus := oldRelease.Info.Status; oldStatus != release.StatusDeployed {
t.Errorf("Expected Deployed status on previous Release version. Got %v", oldStatus)
}
}
func TestUpdateReleaseFailure_Force(t *testing.T) {
rs := rsFixture(t)
rel := namedReleaseStub("forceful-luke", release.StatusFailed)
rs.Releases.Create(rel)
req := &hapi.UpdateReleaseRequest{
Name: rel.Name,
DisableHooks: true,
Chart: &chart.Chart{
Metadata: &chart.Metadata{Name: "hello"},
Templates: []*chart.File{
{Name: "templates/something", Data: []byte("text: 'Did you ever hear the tragedy of Darth Plagueis the Wise? I thought not. It’s not a story the Jedi would tell you. It’s a Sith legend. Darth Plagueis was a Dark Lord of the Sith, so powerful and so wise he could use the Force to influence the Midichlorians to create life... He had such a knowledge of the Dark Side that he could even keep the ones he cared about from dying. The Dark Side of the Force is a pathway to many abilities some consider to be unnatural. He became so powerful... The only thing he was afraid of was losing his power, which eventually, of course, he did. Unfortunately, he taught his apprentice everything he knew, then his apprentice killed him in his sleep. Ironic. He could save others from death, but not himself.'")},
},
},
Force: true,
}
res, err := rs.UpdateRelease(req)
if err != nil {
351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420
t.Errorf("Expected successful update, got %v", err)
}
if updatedStatus := res.Info.Status; updatedStatus != release.StatusDeployed {
t.Errorf("Expected DEPLOYED release. Got %s", updatedStatus)
}
compareStoredAndReturnedRelease(t, *rs, res)
expectedDescription := "Upgrade complete"
if got := res.Info.Description; got != expectedDescription {
t.Errorf("Expected description %q, got %q", expectedDescription, got)
}
oldRelease, err := rs.Releases.Get(rel.Name, rel.Version)
if err != nil {
t.Errorf("Expected to be able to get previous release")
}
if oldStatus := oldRelease.Info.Status; oldStatus != release.StatusUninstalled {
t.Errorf("Expected Deleted status on previous Release version. Got %v", oldStatus)
}
}
func TestUpdateReleaseNoHooks(t *testing.T) {
rs := rsFixture(t)
rel := releaseStub()
rs.Releases.Create(rel)
req := &hapi.UpdateReleaseRequest{
Name: rel.Name,
DisableHooks: true,
Chart: &chart.Chart{
Metadata: &chart.Metadata{Name: "hello"},
Templates: []*chart.File{
{Name: "templates/hello", Data: []byte("hello: world")},
{Name: "templates/hooks", Data: []byte(manifestWithUpgradeHooks)},
},
},
}
res, err := rs.UpdateRelease(req)
if err != nil {
t.Fatalf("Failed updated: %s", err)
}
if hl := res.Hooks[0].LastRun; !hl.IsZero() {
t.Errorf("Expected that no hooks were run. Got %s", hl)
}
}
func TestUpdateReleaseNoChanges(t *testing.T) {
rs := rsFixture(t)
rel := releaseStub()
rs.Releases.Create(rel)
req := &hapi.UpdateReleaseRequest{
Name: rel.Name,
DisableHooks: true,
Chart: rel.Chart,
}
_, err := rs.UpdateRelease(req)
if err != nil {
t.Fatalf("Failed updated: %s", err)
}
}
func compareStoredAndReturnedRelease(t *testing.T, rs ReleaseServer, res *release.Release) *release.Release {
storedRelease, err := rs.Releases.Get(res.Name, res.Version)
421422423424425426427428429430431
if err != nil {
t.Fatalf("Expected release for %s (%v).", res.Name, rs.Releases)
}
if !reflect.DeepEqual(storedRelease, res) {
t.Errorf("Stored release doesn't match returned Release")
}
return storedRelease
}