Commit 82d01cb3 authored by Morten Torkildsen's avatar Morten Torkildsen Committed by Matthew Fisher
Browse files

fix(helm): Merge nested values correctly on upgrade (#4806)


Upgrading a release and override existing values doesn't work as expected for nested values. Maps should be merged recursively, but currently maps are treated just like values and replaced at the top level.

If the existing values are:
```yaml
resources:
  requests:
    cpu: 400m
  something: else
```
and an update is done with ```--set=resources.requests.cpu=500m```, it currently ends up as
```yaml
resources:
  requests:
    cpu: 500m
```
but it should have been
```yaml
resources:
  requests:
    cpu: 500m
  something: else
```

This PR updates the way override values are merged into the existing set of values to merge rather than replace maps.

Closes: #4792

Signed-off-by: default avatarMorten Torkildsen <mortent@google.com>
parent e91e9615
Showing with 178 additions and 14 deletions
+178 -14
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment