1. 09 Dec, 2020 2 commits
  2. 11 Nov, 2020 21 commits
  3. 19 Oct, 2020 5 commits
  4. 15 Oct, 2020 3 commits
  5. 14 Oct, 2020 1 commit
  6. 13 Oct, 2020 2 commits
  7. 12 Oct, 2020 1 commit
  8. 05 Oct, 2020 1 commit
  9. 02 Oct, 2020 1 commit
  10. 01 Oct, 2020 1 commit
  11. 30 Sep, 2020 2 commits
    • Li Zhijian's avatar
      Makefile: check and use GOBIN environment variable first · e97975d7
      Li Zhijian authored
      'go get' will install binaries into GOBIN when it's set which is not
      always same with GOPATH/bin
      
      this commit can fix below errors:
      ~/workspace/k8s/helm$ go env | grep -e GOPATH -e GOBIN -e GOROO
      GOBIN="/home/lizj/go/bin"
      GOPATH="/home/lizj/gosrc"
      GOROOT="/home/lizj/go"
      ~/workspace/k8s/helm$ make build-cross
      (cd /; GO111MODULE=on go get -u github.com/mitchellh/gox)
      go: github.com/mitchellh/gox upgrade => v1.0.1
      go: github.com/hashicorp/go-version upgrade => v1.2.1
      GO111MODULE=on CGO_ENABLED=0 /home/lizj/gosrc/bin/gox -parallel=3 -output="_dist/{{.OS}}-{{.Arch}}/helm" -osarch='darwin/amd64 linux/amd64 linux/386 linux/arm linux/arm64 linux/ppc64le linux/s390x windows/amd64'  -tags '' -ldflags '-w -s -X helm.sh/helm/v3/internal/version.metadata=unreleased -X helm.sh/helm/v3/internal/version.gitCommit=59c77716
      
       -X helm.sh/helm/v3/internal/version.gitTreeState=dirty  -extldflags "-static"' ./cmd/helm
      bash: /home/lizj/gosrc/bin/gox: No such file or directory
      Makefile:146: recipe for target 'build-cross' failed
      make: *** [build-cross] Error 127
      
      Signed-off-by: default avatarLi Zhijian <lizhijian@cn.fujitsu.com>
      e97975d7
    • Li Zhijian's avatar
      TestCheckPerms: utilize pipe to read stderr · 59c77716
      Li Zhijian authored
      
      Refer to the stderr manpage:
      $ man 3 stderr
      *Note that mixing use of FILEs and raw file descriptors can produce unexpected results and should generally be avoided.*
      
      And actually, we noticed that the warning() will output the message to
      stdout instead of stderr sometimes.
      
      lizj@FNSTPC:~/workspace/k8s/helm$ while true; do timeout 1m go test -count=1  -run TestCheckPerms ./cmd/helm -v 2>/dev/null; done
      === RUN   TestCheckPerms
      --- PASS: TestCheckPerms (0.00s)
      PASS
      ok  	helm.sh/helm/v3/cmd/helm	0.028s
      === RUN   TestCheckPerms
      --- PASS: TestCheckPerms (0.00s)
      PASS
      ok  	helm.sh/helm/v3/cmd/helm	0.027s
      === RUN   TestCheckPerms
      --- PASS: TestCheckPerms (0.00s)
      PASS
      ok  	helm.sh/helm/v3/cmd/helm	0.028s
      === RUN   TestCheckPerms
      --- PASS: TestCheckPerms (0.00s)
      PASS
      ok  	helm.sh/helm/v3/cmd/helm	0.029s
      === RUN   TestCheckPerms
      --- PASS: TestCheckPerms (0.00s)
      PASS
      ok  	helm.sh/helm/v3/cmd/helm	0.029s
      === RUN   TestCheckPerms
      --- PASS: TestCheckPerms (0.00s)
      PASS
      ok  	helm.sh/helm/v3/cmd/helm	0.028s
      === RUN   TestCheckPerms
      --- PASS: TestCheckPerms (0.00s)
      PASS
      ok  	helm.sh/helm/v3/cmd/helm	0.030s
      === RUN   TestCheckPerms
      WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /tmp/helmtest093620773/testconfig
      === RUN   TestCheckPerms
      WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /tmp/helmtest083469215/testconfig
      === RUN   TestCheckPerms
      WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /tmp/helmtest101343249/testconfig
      === RUN   TestCheckPerms
      --- PASS: TestCheckPerms (0.00s)
      PASS
      ok  	helm.sh/helm/v3/cmd/helm	0.032s
      === RUN   TestCheckPerms
      --- PASS: TestCheckPerms (0.00s)
      PASS
      ok  	helm.sh/helm/v3/cmd/helm	0.040s
      === RUN   TestCheckPerms
      --- PASS: TestCheckPerms (0.00s)
      PASS
      ok  	helm.sh/helm/v3/cmd/helm	0.031s
      === RUN   TestCheckPerms
      WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /tmp/helmtest706352639/testconfig
      
      Signed-off-by: default avatarLi Zhijian <lizhijian@cn.fujitsu.com>
      Signed-off-by: default avatarLu Fengqi <lufq.fnst@cn.fujitsu.com>
      59c77716