Merge pull request #3193 from burdiyan/master

ref(helm): improve fullname template in starter chart

Merge pull request #3193 from burdiyan/master
ref(helm): improve fullname template in starter chart
7c79d1c7 · Matthew Fisher · GitHub · 8ca89cfb · f432e071 · 7c79d1c7
Unverified Commit 7c79d1c7 authored 7 years ago by Matthew Fisher Committed by GitHub 7 years ago
Hide whitespace changes
Inline Side-by-side

Showing

with 6 additions and 2 deletions
+6 -2
--- a/pkg/chartutil/create.go
+++ b/pkg/chartutil/create.go
@@ -237,11 +237,15 @@ Expand the name of the chart.
 {{/*
 Create a default fully qualified app name.
 We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec).
+If release name contains chart name it will be used as a full name.
 */}}
 {{- define "<CHARTNAME>.fullname" -}}
 {{- $name := default .Chart.Name .Values.nameOverride -}}
-{{- $default := printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" -}}
+{{- if contains $name .Release.Name -}}
-{{- default $default .Values.fullnameOverride -}}
+{{- .Release.Name | trunc 63 | trimSuffix "-" -}}
+{{- else -}}
+{{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" -}}
+{{- end -}}
 {{- end -}}
 `